RFR: 8265285: Unnecessary inclusion of bytecodeHistogram.hpp

[Yi Yang]

On Fri, 16 Apr 2021 06:27:07 GMT, Yi Yang <yyang at openjdk.org> wrote:

> > > Looks like these files refer to `(BytecodeCounter)|(BytecodeHistogram)(BytecodePairHistogram)` but are missing the inclusion of bytecodeHistogram.hpp
> > > 
> > > * cpu/aarch64/macroAssembler_aarch64.cpp
> > > * cpu/arm/macroAssembler_arm.cpp
> > > * cpu/x86/macroAssembler_x86.cpp
> > > 
> > > See https://github.com/iklam/tools/blob/main/headers/find_include_problems.sh
> > > The problems can usually be found by building without precompiled headers.
> > 
> > 
> > Yes, the inclusion of bytecodeHistogram.hpp in sharedRuntime.hpp should remain, others are really unnecessary.(Build without precompile header)
> 
> sharedRuntime.hpp does not need to include bytecodeHistogram.hpp, since it doesn't use any of the 3 classes declared in bytecodeHistogram.hpp. You should add bytecodeHistogram.hpp to the 3 files I listed above instead.

Hi Ioi, I've added `#include "interpreter/bytecodeHistogram.hpp"` in macroAssembler_<cpu>.cpp you listed above. Build passed w and w/o precompile header in x64.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3530