RFR: 8265327: Remove check_safepoint_and_suspend_for_native_trans() [v2]

[David Holmes]

On Mon, 19 Apr 2021 19:41:50 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Patricio Chilano Mateo has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix typo in comment for check_special_condition_for_native_trans
>
> src/hotspot/share/runtime/thread.hpp line 1325:
> 
>> 1323:     // under SR_lock in java_suspend_self().
>> 1324:     return (_special_runtime_exit_condition != _no_async_condition) ||
>> 1325:            (_suspend_flags & (_external_suspend | _obj_deopt JFR_ONLY(| _trace_flag))) != 0;
> 
> I don't see this change mentioned in the bug report and it's
> not obvious why you're changing this code. Also, I think this
> is going to conflict with @robehn fix for JDK-8257831.

Unless there is some significant performance issue with the lack of inlining I'd prefer to maintain code readability. And with Robbin's change is the inlining simplified anyway? Otherwise perhaps we should (re-)introduce is_any_suspend() to encapsulate the _suspend_flag checking?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3548