RFR: 8263236: runtime/os/TestTracePageSizes.java fails on old kernels [v2]
David Holmes
dholmes at openjdk.java.net
Wed Apr 21 10:56:36 UTC 2021
On Sat, 10 Apr 2021 05:59:43 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> See the bug report for details. On some kernels, the madvise hint is not reflected in `/proc/smaps`. Instead, we can use a secondary evidence and read `AnonHugePages`.
>>
>> Additional testing:
>> - [x] Test with kernel 5.4.0 (still passes)
>> - [x] Test with kernel 4.9.0 (used to fail, now passes)
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Merge branch 'master' into JDK-8263236-trace-page-sizes
> - Make jcheck happy: remove the TAB
> - 8263236: runtime/os/TestTracePageSizes.java fails on old kernels
Hi Aleksey,
I can't really evaluate the changes as I'm not familiar with the information that is being queried. I get the gist of things and as this is a test the real question is whether the test now passes okay. So on that basis I'll approve it.
Thanks,
David
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3415
More information about the hotspot-runtime-dev
mailing list