RFR: 8261090: Store old classfiles in static CDS archive [v3]

[Calvin Cheung]

On Wed, 21 Apr 2021 18:07:48 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   move the setting of shared old class bit to InstanceKlass::remove_unshareable_info
>
> src/hotspot/share/classfile/verifier.cpp line 291:
> 
>> 289:     // However, bytecodes for shared old classes can be verified because
>> 290:     // they have not been rewritten.
>> 291:     (!(klass->is_shared() && klass->is_rewritten())) &&
> 
> the outmost brackets are not necessary. Could your remove it?

Fixed. I also removed the extra include of metaspaceShared.hpp.

> test/hotspot/jtreg/runtime/cds/appcds/OldSuperInf.java line 56:
> 
>> 54:         OutputAnalyzer output = TestCommon.dump(appJar, appClasses, "-Xlog:class+load,cds=debug,verification=trace");
>> 55:         TestCommon.checkExecReturn(output, 0,
>> 56:                                    dynamicMode ? true : false,
> 
> Why use a ternary operator, is it the variable itself OK here?

I prefer to leave it as is because the third arg to `TestCommon.checkExecReturn()` is about whether or not to look for the strings in the subsequent args.

Thanks for your review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3479