RFR: 8265682: G1: Mutex::_name dangling in HeapRegionRemSet references after JDK-8264146
David Holmes
dholmes at openjdk.java.net
Mon Apr 26 07:42:28 UTC 2021
On Thu, 22 Apr 2021 19:25:50 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> This change makes the Mutex constructor stdup the name passed in for the few cases that the name is constructed on the stack. Most names are shorter than 64 characters so it's still a savings.
> Tested with tier1.
Hi Coleen,
LGTM.
The strdup may have a slight impact on startup, but no more so than the previous implementation, so I think at worst we are back where we were. And we still get the memory savings, which was the primary goal.
Thanks,
David
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3639
More information about the hotspot-runtime-dev
mailing list