RFR: 8265682: G1: Mutex::_name dangling in HeapRegionRemSet references after JDK-8264146 [v2]

Coleen Phillimore coleenp at openjdk.java.net
Mon Apr 26 12:33:25 UTC 2021


On Mon, 26 Apr 2021 12:30:54 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This change makes the Mutex constructor stdup the name passed in for the few cases that the name is constructed on the stack.  Most names are shorter than 64 characters so it's still a savings.
>> Tested with tier1.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use ASSERT_STREQ

Thanks David and Stefan for the reviews.  The name is only used in debugging so if we had any reason to suspect performance regression we could ifdef it.  I don't think it's worth doing that and it's good that it would be available in product right now.
Kim pointed out offline that I could use ASSERT_STREQ so I made the trivial change in the patch.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3639


More information about the hotspot-runtime-dev mailing list