RFR: 8266017: Refactor the *klass::array_klass_impl code to separate the non-exception-throwing API [v3]

[Ioi Lam]

On Tue, 27 Apr 2021 22:55:27 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> We currently have array_klass() and array_klass_or_null(), where the former can throw exceptions and the latter can not. But they both delegate to:
>> 
>> array_klass_impl(bool or_null, TRAPS)
>> 
>> which combines both the exception-throwing and non-exception-throwing code into one method declared with TRAPS. To make progress with the change of TRAPS to JavaThread (JDK-8252685) we need to separate these code paths into distinct methods.
>> 
>> Testing: tiers 1-3 (in progress)
>> 
>> Thanks,
>> David
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated comment and simplify code structure in one method

Latest version looks good.

-------------

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3711