RFR: 8266170: -Wnonnull happens in classLoaderData.inline.hpp

Yasumasa Suenaga ysuenaga at openjdk.java.net
Wed Apr 28 13:34:50 UTC 2021


On Wed, 28 Apr 2021 12:37:57 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> We can see compiler warnings in dictionary.cpp as following on GCC 11. Conditions in `guarantee` should be changed.
>> 
>> 
>> In file included from /home/ysuenaga/git-forked/jdk/src/hotspot/share/utilities/globalDefinitions.hpp:29,
>>                  from /home/ysuenaga/git-forked/jdk/src/hotspot/share/memory/allocation.hpp:29,
>>                  from /home/ysuenaga/git-forked/jdk/src/hotspot/share/classfile/classLoaderData.hpp:28,
>>                  from /home/ysuenaga/git-forked/jdk/src/hotspot/share/precompiled/precompiled.hpp:34:
>> In member function 'oop ClassLoaderData::class_loader() const',
>>     inlined from 'void Dictionary::verify()' at /home/ysuenaga/git-forked/jdk/src/hotspot/share/classfile/dictionary.cpp:635:3:
>
> This change looks good to me.
> 
> I'll ask Coleen to confirm.
> 
> Thanks,
> David

Thanks @dholmes-ora and @coleenp for your review!

-------------

PR: https://git.openjdk.java.net/jdk/pull/3753


More information about the hotspot-runtime-dev mailing list