RFR: 8265933: Move Java monitor related fields from class Thread to JavaThread

David Holmes dholmes at openjdk.java.net
Wed Apr 28 21:15:52 UTC 2021


On Tue, 27 Apr 2021 18:08:19 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

> Hi,
> 
> Please review the following change. Fields in class Thread related to Java object monitors like _current_pending_monitor, _current_pending_monitor_is_from_java, _current_waiting_monitor and _Stalled should be moved to the JavaThread class. Members _OnTrap and _TypeTag were grouped together with _Stalled but are not used so I removed them. It seems they were part of the ObjectMonitor implementation at some point but I couldn't find how they were used.
> Tested in mach5 tier1-2.
> 
> Thanks,
> Patricio

Hi Patricio,

Changes look good!

The two unused fields appear to have never been used. They were added, but not used, in JDK 6.0b59 (JDK-5030359). I can only assume they were part of experimental code that never made it into the product.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3722


More information about the hotspot-runtime-dev mailing list