RFR: 8271513: support JavaThreadIteratorWithHandle replacement by new ThreadsList::Iterator [v3]

Coleen Phillimore coleenp at openjdk.java.net
Tue Aug 3 18:54:34 UTC 2021


On Mon, 2 Aug 2021 17:25:47 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> A trivial fix to support JavaThreadIteratorWithHandle replacement by new ThreadsList::Iterator.
>> 
>> This fix was tested with Mach5 Tier[1-3].
>
> Daniel D. Daugherty has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
> 
>  - Merge branch 'master' into JDK-8271513
>  - Merge branch 'pull/4671' into JDK-8271513
>  - kbarrett CR - simplify 'ThreadsList::Iterator::operator!=(Iterator i)'
>  - 8271513: support JavaThreadIteratorWithHandle replacement by new ThreadsList::Iterator
>  - 8193559.kbarrett.part1 - Kim's proposed rewrite using newer C++ features.
>  - Merge branch 'master' into JDK-8193559
>  - kbarrett CR - delete unused _list member.
>  - 8193559.cr0

src/hotspot/share/runtime/thread.cpp line 857:

> 855:     array[i] = _jvmci_old_thread_counters[i];
> 856:   }
> 857:   for (JavaThread* tp : ThreadsListHandle()) {

This is a nicer interface with underlying C++ magic.  There are lots of these in the source code.  Is it the intention to replace these as we go?

-------------

PR: https://git.openjdk.java.net/jdk/pull/4948


More information about the hotspot-runtime-dev mailing list