RFR: 8271931: Make AbortVMOnVMOperationTimeout more resilient to OS scheduling [v2]

[Albert Mingkun Yang]

On Fri, 6 Aug 2021 15:26:51 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/runtime/vmThread.cpp line 93:
> 
>> 91:     fatal("%s VM operation took too long: completed in " JLONG_FORMAT " ms (timeout: " INTX_FORMAT " ms)",
>> 92:           _vm_op_name, vm_op_duration, AbortVMOnVMOperationTimeoutDelay);
>> 93:   }
> 
> Should we null `_vm_op_name` here?

It's not read by anyone from here on, so setting it to null is not needed, and a waste of the VM thread time.

> src/hotspot/share/runtime/vmThread.hpp line 42:
> 
>> 40:   volatile int _armed;
>> 41:   jlong _arm_time;
>> 42:   const char* _vm_op_name = nullptr;
> 
> Style question: are we doing these inits inline, instead of constructor?

My mistake; I will fix it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5016