RFR: 8271931: Make AbortVMOnVMOperationTimeout more resilient to OS scheduling [v2]
Albert Mingkun Yang
ayang at openjdk.java.net
Sat Aug 7 10:12:56 UTC 2021
On Sat, 7 Aug 2021 05:42:38 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> It's not read by anyone from here on, so setting it to null is not needed, and a waste of the VM thread time.
>
> My concern would be holding the pointer to something that is already unallocated long after VM op completes. I guess it is a lower risk for `const char*`, which is probably a reference to globally available string, but anyway. The overhead argument does not seem very relevant here, as we do other stuff in this handler when it is enabled. It is not a waste in default VM mode.
I see; cleared `_vm_op_name` at the end of `disarm()`.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5016
More information about the hotspot-runtime-dev
mailing list