RFR: 8272345: macos doesn't check `os::set_boot_path()` result

[David Holmes]

On Wed, 11 Aug 2021 22:23:42 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

> Hi all,
> 
> could you please review this small fix?
> 
> from JBS:
>> we don't check `os::set_boot_path()` return value on macos, which leads to a crash/assert down the road in case we weren't able to set BCP. on all other OSes, we terminate JVM w/ "Failed setting boot class path." error message.
> 
> testing:
> - [x] tier1
> - [x] `runtime/cds/appcds/MoveJDKTest.java`
> 
> 
> Thanks,
> -- Igor

Hi Igor,

Functional fix looks good. One suggestion with the test.

Thanks,
David

test/hotspot/jtreg/runtime/cds/appcds/MoveJDKTest.java line 30:

> 28:  * @bug 8272345
> 29:  * @requires vm.cds
> 30:  * @requires os.family == "linux" | os.family == "mac"

The test probably works everywhere but Windows if the issue is only symbolic links. If problems were reported on AIX or generic BSD then we could address that then.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5094