Integrated: 8272345: macos doesn't check `os::set_boot_path()` result
Igor Ignatyev
iignatyev at openjdk.java.net
Thu Aug 12 03:50:27 UTC 2021
On Wed, 11 Aug 2021 22:23:42 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:
> Hi all,
>
> could you please review this small fix?
>
> from JBS:
>> we don't check `os::set_boot_path()` return value on macos, which leads to a crash/assert down the road in case we weren't able to set BCP. on all other OSes, we terminate JVM w/ "Failed setting boot class path." error message.
>
> testing:
> - [x] tier1
> - [x] `runtime/cds/appcds/MoveJDKTest.java`
>
>
> Thanks,
> -- Igor
This pull request has now been integrated.
Changeset: bd27bb9c
Author: Igor Ignatyev <iignatyev at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/bd27bb9cbedebd09f589679947ff32261f9ef352
Stats: 12 lines in 2 files changed: 5 ins; 4 del; 3 mod
8272345: macos doesn't check `os::set_boot_path()` result
Reviewed-by: dholmes
-------------
PR: https://git.openjdk.java.net/jdk/pull/5094
More information about the hotspot-runtime-dev
mailing list