RFR: 8269909: getStack method in hprof.parser.Reader should use try-with-resource [v4]

Lin Zang lzang at openjdk.java.net
Thu Aug 12 07:52:25 UTC 2021


On Wed, 14 Jul 2021 05:05:27 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Lin Zang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - fix indentation issue
>>  - Merge branch 'master' into try
>>  - revise code to handle the closing of embeded streams
>>  - Merge branch 'master' into try
>>  - 8269909: getStack method in hprof.parser.Reader should use try-with-resource
>
> The indentation of the first two try-with-resources blocks is still wrong.

Hi @dholmes-ora  and @plummercj,
I think this PR has been there for quite a while, I have no idea for what I can do to make progress, so may I ask your help to sponsor it? or should we wait for Serguei's approve?  Any suggestions? 
Thanks!
- Lin

-------------

PR: https://git.openjdk.java.net/jdk/pull/4717


More information about the hotspot-runtime-dev mailing list