RFR: 8272348: Update CDS tests in anticipation of JDK-8270489 [v3]

Ioi Lam iklam at openjdk.java.net
Sat Aug 14 01:28:25 UTC 2021


On Fri, 13 Aug 2021 23:11:23 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @iignatev comments -- sync up jdk/test/whitebox/WhiteBox.java to match the latest sun/hotspot/WhiteBox.java APIs
>
> test/lib/jdk/test/whitebox/WhiteBox.java line 609:
> 
>> 607:   // Handshakes
>> 608:   public native int handshakeWalkStack(Thread t, boolean all_threads);
>> 609:   public native boolean handshakeReadMonitors(Thread t);
> 
> Why is this function added?

We have two WhiteBox classes: sun.hotspot.WhiteBox and jdk.test.whitebox.WhiteBox. They should have the exact same contents, but handshakeReadMonitors is missing from jdk.test.whitebox.WhiteBox. So I added it since I am changing this file.

https://bugs.openjdk.java.net/browse/JDK-8271707 will remove sun.hotspot.WhiteBox so we won't have this duplication anymore.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5095


More information about the hotspot-runtime-dev mailing list