RFR: 8272526: Cleanup ThreadStateTransition class [v2]

Patricio Chilano Mateo pchilanomate at openjdk.java.net
Tue Aug 24 14:09:33 UTC 2021


On Tue, 24 Aug 2021 05:02:39 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> If the unsafe access error happens on Unsafe_CopySwapMemory0 like in the test then we will be either in vm or native (depending on src & dst) which will also output the same error message. We can differentiate between this cases if we want by saving the state in SharedRuntime::handle_unsafe_access().
>
> Sorry for the delay in getting back to this. There are a lot of subtleties around the throwing of an async exception related to "unsafe access errors" and I had to dig around to refresh my memory on a few things. End result: changing the error messages to say the same thing is fine.

Thanks for the review David!

-------------

PR: https://git.openjdk.java.net/jdk/pull/5128


More information about the hotspot-runtime-dev mailing list