RFR: 8268288: jdk/jfr/api/consumer/streaming/TestOutOfProcessMigration.java fails with "Error: ShouldNotReachHere()"

[Yumin Qi]

On Wed, 1 Dec 2021 19:16:11 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> A small fix to ensure that the globally shared ClassPathImageEntry is not being deleted in CDS code.
> The test failure is hard to reproduce. The proposed fix passed CI tiers 1-4 testing.
> Currently running the TestOutOfProcessMigration.java test repeatedly on linux-x64 with the vm options in the bug report.

LGTM. Minor suggestion.

src/hotspot/share/cds/filemap.cpp line 2495:

> 2493:     const char* path = scpe->name();
> 2494:     struct stat st;
> 2495:     if (os::stat(path, &st) != 0) {

Do you check if the file exists? If so please use os::file_exists which is better.

-------------

Marked as reviewed by minqi (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6651