RFR: 8278638: Remove FLAG_IS_CMDLINE(UseSharedSpaces)

[Harold Seigel]

On Tue, 14 Dec 2021 17:37:25 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> Please review this small fix for bug JDK-827638.  The fix was tested by running Mach5 tiers 1 and 2 on Linux, Mac OS, and Windows, Mach5 tier 4 on Linux x64, and by building on linux-aarch64-zero and linux-x64-zero.
>> 
>> Thanks, Harold
>
> src/hotspot/share/runtime/arguments.cpp line 3999:
> 
>> 3997:     return JNI_ERR;
>> 3998:   }
>> 3999:   if ((UseSharedSpaces && xshare_auto_cmd_line) ||
> 
> xshare_auto_cmd_line is set with UseSharedSpaces (line 2715) so it should be OK to check only for itself.

Hi Yumin, thanks for looking at this.  If someone had a command line that contained the equivalent of -Xshare:auto ... -Xshare:off then, if only xshare_auto_cmd_line was checked, they would get the warning even though UseSharedSpaces was false.  So, I'd like to keep the existing check.  Thanks, Harold

-------------

PR: https://git.openjdk.java.net/jdk/pull/6835