RFR: 8278638: Remove FLAG_IS_CMDLINE(UseSharedSpaces)
David Holmes
dholmes at openjdk.java.net
Tue Dec 14 21:42:00 UTC 2021
On Tue, 14 Dec 2021 16:06:28 GMT, Harold Seigel <hseigel at openjdk.org> wrote:
> Please review this small fix for bug JDK-827638. The fix was tested by running Mach5 tiers 1 and 2 on Linux, Mac OS, and Windows, Mach5 tier 4 on Linux x64, and by building on linux-aarch64-zero and linux-x64-zero.
>
> Thanks, Harold
Do we need to warn in this case? The original gave a warning because the user explicitly set UseSharedSpaces=true but CDS was not usable. But Xshare:auto just says "use CDS if you can", so if CDS is not available it is no big deal. The equivalent to the old code with be if the user set Xshare:on. Do we warn in other situations if Xshare:auto doesn't lead to sharing being enabled?
-------------
PR: https://git.openjdk.java.net/jdk/pull/6835
More information about the hotspot-runtime-dev
mailing list