[jdk18] RFR: 8273107: RunThese24H times out with "java.lang.management.ThreadInfo.getLockName()" is null

Wed Dec 15 18:36:06 UTC 2021

On Wed, 15 Dec 2021 13:49:02 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Ah I see (well I don't really see as this is very obscure). I would have expected `CleanupObjectMonitorsHashtable` to be a subtype of something that I could then see is used by the ResourceHashtable. I'm going to guess that there is some template usage here that ensures the passed in object has the right API even if there is no subtyping relationship. Hard to see these connections at a distance.
>> 
>> To be clear not a review as I don't understand our Hashtable's enough to make much sense of what is actually happening here.
>
> It would be a nice place for a lambda (on the list of future RFEs).  You could also put this class in scope of the function that calls it which might help.  (optional)

ResourceHashtable::unlink() is definitely one of those template
things that I don't really like, but I have to use it... All that stuff
is in src/hotspot/share/utilities/resourceHash.hpp, but I don't
see any precedent for putting the CleanupObjectMonitorsHashtable
definition in there. I think I'll leave it where it is.

-------------

PR: https://git.openjdk.java.net/jdk18/pull/25