RFR: 8278131: runtime/cds/appcds/dynamicArchive/* tests failing in loom repo [v3]

[David Holmes]

On Wed, 15 Dec 2021 23:57:36 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> A few dynamic archive CDS tests are failing in the loom repo due to more aggressive GC of code cache
>> which leads to unloading of some classes before being written into a dynamic CDS archive.
>> 
>> This change is to make the affected tests more reliable by ensuring the test classes are not unloaded
>> during dynamic CDS dump time.
>> 
>> Testing: Oracle CI tiers 1,2,4.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add comments to helper classes

The test changes are acceptable and so the PR "approved" on that basis.

But I can't help but wonder what this class unloading issue means for dynamic dumping in general? Seems like the dump contents will depend on a GC race.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6843