RFR: 8279018: CRC calculation in CDS should not include _version and _head_size

Ioi Lam iklam at openjdk.java.net
Mon Dec 20 22:07:32 UTC 2021


On Mon, 20 Dec 2021 20:30:15 GMT, Yumin Qi <minqi at openjdk.org> wrote:

> Please review the simple change for not including _version and _header_size in crc computation. These two fields are checked separately and they should not affect crc.
> 
> tests: tier1,tier4
> 
> Thanks
> Yumin

Hi Yumin, because the layout of the header has changed, CURRENT_CDS_ARCHIVE_VERSION needs to be updated to 13.

Also, CDS_GENERIC_HEADER_SUPPORTED_MIN_VERSION needs to be updated to 13, since this PR changes the layout of GenericCDSFileMapHeader.

-------------

Changes requested by iklam (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6899


More information about the hotspot-runtime-dev mailing list