RFR: 8267517: async logging for stdout and stderr [v3]
Xin Liu
xliu at openjdk.java.net
Tue Dec 21 02:35:13 UTC 2021
On Tue, 14 Dec 2021 02:01:09 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix typo and the building eror on MacOS.
>
> Hi Xin,
>
> I took a look at this but to be honest I couldn't work out what most of the changes actually had to do with the topic of adding async logging for stdout/stderr. IIUC the change from `LogFileOutput` to `LogFileStreamOutput` in the API now enables it to be used for stdout/stderr - right? But most of the changes seemed to relate to log file rotation which doesn't even apply to stdout/stderr! What has force_rotation got to do with things?
>
> David
hi, @dholmes-ora ,
I update the the PR, stripping JDK-8275083. As a result, UL throughput to STDOUT increases 15% with -Xlog:async.
It was 20% with JDK-8275083 but I don't think the 5% gain justifies the bigger patch. This patch is now smaller. Could you take a look?
-------------
PR: https://git.openjdk.java.net/jdk/pull/6132
More information about the hotspot-runtime-dev
mailing list