RFR: 8267517: async logging for stdout and stderr [v3]

Xin Liu xliu at openjdk.java.net
Tue Dec 21 22:15:28 UTC 2021


On Tue, 21 Dec 2021 02:43:13 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typo and the building eror on MacOS.
>
> src/hotspot/share/logging/logAsyncWriter.cpp line 155:
> 
>> 153:     // LogFileOutput::write_block() has called fflush().
>> 154:     // stderr does not cache.
>> 155:     fflush(stdout);
> 
> if `LogFileOutput::write_block() has called fflush()` why are we calling it here?

because `LogFileStreamOutput::write_blocking()` doesn't call fflush(), therefore, we need to do special treat for STDOUT here.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6132


More information about the hotspot-runtime-dev mailing list