RFR: 8279018: CRC calculation in CDS should not include _version and _head_size [v3]

Calvin Cheung ccheung at openjdk.java.net
Wed Dec 22 03:35:15 UTC 2021


On Wed, 22 Dec 2021 03:16:55 GMT, Yumin Qi <minqi at openjdk.org> wrote:

>> Please review the simple change for not including _version and _header_size in crc computation. These two fields are checked separately and they should not affect crc.
>> 
>> tests: tier1,tier4
>> 
>> Thanks
>> Yumin
>
> Yumin Qi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Explicitly include cds.h and add INCLUDE_CDS for CDS only code

Update seems fine.

-------------

Marked as reviewed by ccheung (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6899


More information about the hotspot-runtime-dev mailing list