RFR: 8278125: Some preallocated OOMEs are missing stack trace [v5]

[Coleen Phillimore]

On Wed, 22 Dec 2021 08:20:51 GMT, Yi Yang <yyang at openjdk.org> wrote:

>> Our customer found that the PreallocatedOutOfMemoryErrorCount is 4 by default. It ought to pre-allocate 4 OOMEs with stack trace, but in fact, no matter how many OOMEs are thrown, only 2 OOMEs have proper stack trace. This is because PreallocatedOutOfMemoryErrorCount is consumed multiple times:
>> 
>> VM tries to allocate a huge object while Java heap is insufficient to accommodate, it goes to:
>> 
>> https://github.com/openjdk/jdk/blob/b79554bb5cef14590d427543a40efbcc60c66548/src/hotspot/share/gc/shared/memAllocator.cpp#L115-L136
>> 
>> Line 135(`Universe::out_of_memory_error_java_heap`->`Universe::gen_out_of_memory_error`) and line 136(`THROW_OOP_`->`Exceptions::_throw`->`Exceptions::count_out_of_memory_exceptions`->`Universe::out_of_memory_error_java_heap`->`Universe::gen_out_of_memory_error`) call `Universe::gen_out_of_memory_error` twice in a single OOM event, which leads this unexpected scenario. Proposed fix is to remove such call in `Exceptions::count_out_of_memory_exceptions`.
>> 
>> Thanks.
>
> Yi Yang has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - typo
>  - cleanup

I like this.  No more strcmp where I have to worry whether you should have had strncmp, or not.  Thanks!

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6672