RFR: 8279189: Inaccurate comment about class VMThread

David Holmes dholmes at openjdk.java.net
Thu Dec 23 02:07:14 UTC 2021


On Thu, 23 Dec 2021 01:14:50 GMT, Xin Liu <xliu at openjdk.org> wrote:

> The comment is inaccurate now. VMThread is different from the primordial thread. I guess the comment is based on the old codebase.
> Because VMThread is singleton, I put the Constructor and Destructor in "private" section. clients use static member functions create/destroy.

I don't know if that comment has ever been accurate :)

Changes look fine and trivial IMO. I think loop() could/should also be private.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6922


More information about the hotspot-runtime-dev mailing list