RFR: 8279189: Inaccurate comment about class VMThread [v2]

Xin Liu xliu at openjdk.java.net
Thu Dec 23 21:44:22 UTC 2021


On Thu, 23 Dec 2021 21:14:49 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> The comment is inaccurate now. VMThread is different from the primordial thread. I guess the comment is based on the old codebase.
>> Because VMThread is singleton, I put the Constructor and Destructor in "private" section. clients use static member functions create/destroy.
>
> Xin Liu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8279189
>  - hide VMThread::loop as well.
>  - 8279189: Inaccurate comment about class VMThread

Reasonable. Tuck away VMThread::loop() in the private section as well.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6922


More information about the hotspot-runtime-dev mailing list