RFR: 8213226: [TESTBUG] Reduce the usage of CDSTestUtils.executeAndLog() [v2]

Ioi Lam iklam at openjdk.java.net
Mon Feb 1 21:37:43 UTC 2021


On Mon, 1 Feb 2021 17:03:14 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Please review this CDS tests cleanup for reducing the usage of `CDSTestUtils.executeAndLog()` by making use of `CDSTestUtils.run()`, `CDSTestUtils.createArchiveAndCheck()`, etc.
>> 
>> Testing: tiers 1 - 4.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   1. revert the changes in SharedStrings.java.
>   2. replace most of the createArchive() calls with createArchiveAndCheck().
>   3. factor out dumping a class list into the CDSTestUtils.dumpClassList() method.

LGTM.

-------------

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2297


More information about the hotspot-runtime-dev mailing list