RFR: 8260264: Move common os_<unix> inline methods to a common posix source file [v3]

[David Holmes]

On Thu, 28 Jan 2021 21:23:58 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> Please review this fix for JDK-8260264 to move common functions from os_<unix>.inline.hpp files to os_posix.inline.hpp.  Functions ftruncate() and the two numa* functions could also be moved to os_posix.inline.hpp but would require BSD_ONLY and AIX_ONLY macros because of minor differences.
>> 
>> The change was tested by running Mach5 tiers 1,2 on Linux, Mac OS, and Windows, and tiers 3-5 on Linux x64.  Additionally, builds were done on Linux-s390x, Linux-ppc, Linux-arm32, and linux-x86.
>> 
>> Thanks, Harold
>
> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8260264: fix lseek64

Hi Harold,
Thanks for making those updates.  The use of lseek on Linux would have broken 32-bit builds. I don't know if AIX also supports 32-bit builds. On all our 64-bit platforms off_t is 64-bits so we could just use lseek/ftruncate, and only use the "64" variants for 32-bit builds. But what you have also works.

David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2267