RFR: 8259839 SystemDictionary exports too much implementation [v6]

Coleen Phillimore coleenp at openjdk.java.net
Tue Feb 2 12:27:41 UTC 2021


On Tue, 2 Feb 2021 12:21:29 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/classfile/systemDictionary.cpp line 792:
>> 
>>> 790:                 SystemDictionary_lock->wait();
>>> 791:               } else {
>>> 792:               // case 3: traditional with broken classloader lock. wait on first
>> 
>> Why combine these into case 3 instead of keeping two distinct cases as per the original comment?
>
> I could do this.  I could add case 4 for the the broken class_loader lock.  or case 3.1.

I went with 4.  The comment now reads as I understand the code.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2247


More information about the hotspot-runtime-dev mailing list