RFR: JDK-8260902: CDS mapping errors should not lead to unconditional output [v2]

Thomas Stuefe stuefe at openjdk.java.net
Tue Feb 2 17:58:04 UTC 2021


On Tue, 2 Feb 2021 16:57:28 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   revert trc level change for crc errors
>
> src/hotspot/share/memory/filemap.cpp line 1675:
> 
>> 1673: 
>> 1674:   if (VerifySharedSpaces && !region_crc_check(bitmap_base, si->used_aligned(), si->crc())) {
>> 1675:     log_info(cds)("relocation bitmap CRC error");
> 
> I think this one should remain an error -- it means the CDS archive has been corrupted.

I reverted it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2348


More information about the hotspot-runtime-dev mailing list