RFR: JDK-8260902: CDS mapping errors should not lead to unconditional output [v2]

Ioi Lam iklam at openjdk.java.net
Tue Feb 2 18:10:51 UTC 2021


On Tue, 2 Feb 2021 17:58:03 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> There are some places where unconditional error messages are printed to tty for recoverable errors. This is not good since the VM may continue without problems, but those printouts may confuse scripts parsing the VM output, or end up at the wrong places:
>> 
>> See e.g.: https://mail.openjdk.java.net/pipermail/build-dev/2021-February/030256.html
>> 
>> One of these points are mapping errors in CDS. VM will just continue without CDS, so its not a fatal error. 
>> 
>> I fixed some places which clearly were non-fatal while leaving log_error in place for cases which are clearly fatal, or borderline fatal (like rs commit errors). I looked for tests which could have parsed these lines and found none.
>
> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
> 
>   revert trc level change for crc errors

Looks good (and can be considered a trivial change).

-------------

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2348


More information about the hotspot-runtime-dev mailing list