RFR: 8259839 SystemDictionary exports too much implementation [v6]

[David Holmes]

On 2/02/2021 10:20 pm, Coleen Phillimore wrote:
> On Tue, 2 Feb 2021 02:34:44 GMT, David Holmes <dholmes at openjdk.org> wrote:
> 
>>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>>>
>>>    Fix more comments.
>>
>> src/hotspot/share/classfile/systemDictionary.cpp line 245:
>>
>>> 243:       THROW_MSG_CAUSE(vmSymbols::java_lang_NoClassDefFoundError(), class_name->as_C_string(), e);
>>> 244:     } else {
>>> 245:       return; // the caller will throw the incoming exception
>>
>> Thanks for fixing this. It seems we must have some missing test coverage here though.
> 
> The tests wouldn't have caught this since the VM ignored the new exception that this function tried to install below.

A test that expected a particular exception would fail when the VM 
ignored it.

Cheers,
David

> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/2247
>