RFR: 8257234 : Add gz option to SA jmap to write a gzipped heap dump [v14]

[Lin Zang]

On Fri, 29 Jan 2021 22:51:23 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Lin Zang has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - fix an issue of double printing error message.
>>  - fix jcmd jmap issue and add test in BascJMapTest and code refine
>
> test/jdk/sun/tools/jmap/BasicJMapTest.java line 121:
> 
>> 119:         testDumpAll();
>> 120:         testDumpCompressed();
>> 121:         testDumpIllegalCompressedArgs();
> 
> Thanks for updating this test to better check the args, but it looks like I pointed you to the wrong test. This is testing the pmap tool, which already had the gz option. I actually meant for you to add testing for the gz option support you added to "jhsdb jmap --binaryheap" , which is what you added to SALauncher.java. The testing for "jhsdb jmap --binaryheap" is done in test/jdk/sun/tools/jhsdb/HeapDumpTest.java.

Thanks Chris!,
I have created another PR and move jcmd jmap fix and this test case enhancement there. (https://github.com/openjdk/jdk/pull/2399)

I will add the test in HeapDumpTest.java in this PR.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1712