RFR: JDK-8261167: print_process_memory_info add a close call after fopen
Thomas Stuefe
stuefe at openjdk.java.net
Thu Feb 4 17:12:41 UTC 2021
On Thu, 4 Feb 2021 16:54:57 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
> Hello, there is an fopen call opening "proc/self/status" in print_process_memory_info in os_linux.cpp. This call should also have a corresponding fclose-call.
>
> See also the Sonar finding ("Opened stream never closed. Potential resource leak") :
> https://sonarcloud.io/project/issues?id=shipilev_jdk&open=AXck8BNvBBG2CXpcnaeA&resolved=false&severities=BLOCKER&types=BUG
LGTM
-------------
Marked as reviewed by stuefe (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2409
More information about the hotspot-runtime-dev
mailing list