RFR: 8258732: runtime/cds/appcds/dynamicArchive/DynamicArchiveRelocationTest.java fails

[Yumin Qi]

On Thu, 4 Feb 2021 22:24:46 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> On Windows, sometimes the OS picks 0x0000000800000000 as the requested archive base address. This resulting in runtime relocation won't happen. The test expects the `Unmapping region #3` output trace which won't be there if there no relocation. The fix is to adjust the test to look for another output trace in case the matching of the original trace has failed.
> 
> Testing: tier 1 - 4.
> Also ran the test 50 times with tier4 vm options on Windows.

LGTM.

test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/DynamicArchiveRelocationTest.java line 99:

> 97:         String archiveRelocPattern = ".*ArchiveRelocationMode == 1.*";
> 98:         String unmapRgn1Pattern = ".*Unmapping region #1 at base 0x.*";
> 99:         String unmapRgn0Prefix = ".*Unmapping region #0 at base 0x.*";

unmapRgn0Prefix is only used to form unmapRgn0Pattern, they could merge together.

-------------

Marked as reviewed by minqi (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2415