RFR: JDK-8261167: print_process_memory_info add a close call after fopen [v2]

[Matthias Baesken]

On Thu, 4 Feb 2021 23:29:52 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/hotspot/os/linux/os_linux.cpp line 2198:
>> 
>>> 2196:   FILE* f = ::fopen("/proc/self/status", "r");
>>> 2197:   char buf[256];
>>> 2198:   if (f) {
>> 
>> Please don't use implied booleans. This should be:
>> `if (f != NULL) {`
>
> What Dan said. Plus if you are now checking the fopen succeeded shouldn't you also print something if it failed?
> 
> Thanks,
> David

hi Daniel and David, I added a NULL check, and some output.
I noticed that a number of other  fopen calls  miss the NULL check + output in case of failure as well, should I adjust that in another change?

Best regards, Matthias

-------------

PR: https://git.openjdk.java.net/jdk/pull/2409