RFR: 8250989: Consolidate buffer allocation code for CDS static/dynamic dumping [v2]

[Coleen Phillimore]

On Fri, 5 Feb 2021 23:14:48 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @calvinccheung and @tstuefe comments
>
> src/hotspot/share/memory/archiveBuilder.hpp line 208:
> 
>> 206: 
>> 207:   // For global access.
>> 208:   static ArchiveBuilder* _current;
> 
> This is kind of a strange concept since ArchiveBuilder is a StackObj.  Maybe it should just be static if only one thread uses it at a time?

And can a different thread call current() ? yikes.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2296