RFR: 8257234 : Add gz option to SA jmap to write a gzipped heap dump [v15]

Lin Zang lzang at openjdk.java.net
Sat Feb 6 04:56:46 UTC 2021


On Sat, 6 Feb 2021 04:42:32 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Lin Zang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refine help message and also refactor the logic in CommandProcessor
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java line 1807:
> 
>> 1805:                         }
>> 1806:                         filename = "heap.bin.gz";
>> 1807:                     }
> 
> I don't think this section works properly if there is just one argument, and it is the filename, not gz=. Also, there appears to be no test case to catch this bug.

Oh yes, I think there should be a check whether the option is "gz=" first. And I will the test case for that together when with the fix of HeapDumpTest.java.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1712


More information about the hotspot-runtime-dev mailing list