RFR: 8250989: Consolidate buffer allocation code for CDS static/dynamic dumping [v2]

[Ioi Lam]

On Thu, 4 Feb 2021 08:45:32 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @calvinccheung and @tstuefe comments
>
> src/hotspot/share/memory/metaspace.cpp line 690:
> 
>> 688: 
>> 689: #if INCLUDE_CDS
>> 690:   // case (a)
> 
> I'd like to preserve this comment. It makes it easier to understand why the followup check needs to query UseSharedSpaces again instead of being placed in the else path.

OK. I added the comments back, but put it below the call to`MetaspaceShared::initialize_runtime_shared_and_meta_spaces();`

> src/hotspot/share/oops/oop.cpp line 147:
> 
>> 145: 
>> 146: #if INCLUDE_CDS_JAVA_HEAP
>> 147: void oopDesc::set_narrow_klass(narrowKlass nk) {
> 
> Make private and access via a CDS-local friend class?

I am not sure about that. Friend classes can access all private methods.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2296