RFR: 8250989: Consolidate buffer allocation code for CDS static/dynamic dumping [v3]

[Ioi Lam]

On Sat, 6 Feb 2021 13:57:49 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
>> 
>>  - @coleenp and @tstuefe comments
>>  - Merge branch 'master' into 8250989-consolidate-dump-buffer-alloc
>>  - @calvinccheung and @tstuefe comments
>>  - fixed whitespace
>>  - clean up and comments
>>  - move remaining functions to archiveBuilder.cpp
>>  - renamed "default" to "requested"
>>  - started
>
> src/hotspot/share/memory/metaspaceShared.hpp line 239:
> 
>> 237:   // During dynamic dump: _requested_base_address is not always the same as SharedBaseAddress:
>> 238:   // - SharedBaseAddress is used for *reading the base archive*. I.e., CompactHashtable uses
>> 239:   //   it to convery offsets to pointers to Symbols in the base archive.
> 
> Perhaps:
> s/convery/convey/

Thanks for spotting it. It's "convert". I'll fixed it :-)

-------------

PR: https://git.openjdk.java.net/jdk/pull/2296