RFR: JDK-8255884: Metaspace: chunk local commit counter may be stale [v6]
Thomas Stuefe
stuefe at openjdk.java.net
Sun Feb 14 05:47:40 UTC 2021
On Sat, 13 Feb 2021 13:58:21 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix builds
>
> src/hotspot/share/memory/metaspace/metachunk.cpp line 194:
>
>> 192:
>> 193: DEBUG_ONLY(verify();)
>> 194: DEBUG_ONLY(verify_neighborhood();)
>
> Is this verification expensive wrt time in fastdebug? Should it be SOMETIMES?
Should not be terribly expensive, but I will move it into the condition above. Its only needed if we modified the neighbors. That would bring down invocation times considerably.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1291
More information about the hotspot-runtime-dev
mailing list