RFR: 8202750: Reduce the use of get_canonical_path() in CDS [v2]

Calvin Cheung ccheung at openjdk.java.net
Wed Feb 17 22:48:40 UTC 2021


On Wed, 17 Feb 2021 22:18:45 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   per review comments from @iklam
>
> src/hotspot/os/windows/os_windows.cpp line 4488:
> 
>> 4486:   native_file1 = os::native_path(native_file1);
>> 4487:   char* native_file2 = os::strdup(file2);
>> 4488:   native_file2 = os::native_path(native_file2);
> 
> `os::strdup` should `be os::strdup_check_oom`
> 
> Other than that, this PR looks good.

Fixed. I'll do some testing before integrate.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2581


More information about the hotspot-runtime-dev mailing list