RFR: 8261949: fileStream::readln returns incorrect line string [v2]

Yang Yi github.com+5010047+kelthuzadx at openjdk.java.net
Fri Feb 19 02:08:52 UTC 2021


> When the last line does not contain a NEWLINE character, fileStream::readln would read
> truncated line string:
> 
> $ cat file_content:
> AA
> BB
> CC<EOF>
> 
> fileStream::readln result:
> "AA"
> "BB"
> "C"
> 
> This patch address this problem, it works for Posix and Windows since the last character
> of these systems is always '\n'.

Yang Yi has updated the pull request incrementally with one additional commit since the last revision:

  tweak

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2626/files
  - new: https://git.openjdk.java.net/jdk/pull/2626/files/f7bd8206..2e816b2e

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2626&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2626&range=00-01

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2626.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2626/head:pull/2626

PR: https://git.openjdk.java.net/jdk/pull/2626


More information about the hotspot-runtime-dev mailing list