RFR: 8261949: fileStream::readln returns incorrect line string [v2]
David Holmes
dholmes at openjdk.java.net
Fri Feb 19 03:56:40 UTC 2021
On Fri, 19 Feb 2021 02:08:52 GMT, Yang Yi <github.com+5010047+kelthuzadx at openjdk.org> wrote:
>> When the last line does not contain a NEWLINE character, fileStream::readln would read
>> truncated line string:
>>
>> $ cat file_content:
>> AA
>> BB
>> CC<EOF>
>>
>> fileStream::readln result:
>> "AA"
>> "BB"
>> "C"
>>
>> This patch address this problem, it works for Posix and Windows since the last character
>> of these systems is always '\n'.
>
> Yang Yi has updated the pull request incrementally with one additional commit since the last revision:
>
> tweak
Looks good!
Thanks,
David
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2626
More information about the hotspot-runtime-dev
mailing list