RFR: 8262099: jcmd VM.metaspace should report unlimited size if MaxMetaspaceSize isn't specified

Yang Yi github.com+5010047+kelthuzadx at openjdk.java.net
Mon Feb 22 05:20:52 UTC 2021


Hi,

Can I have a review of this minor fix about `jcmd VM.metaspace`?

When MaxMetaspaceSize is not specified, it would set to max_uintx, jcmd VM.metaspace reports metaspace summary information as follows:

$ ./jcmd <pid> VM.metaspace | grep MaxMetaspaceSize
MaxMetaspaceSize: 17179869184.00 GB

Actually, this is a bug, the expected output should be:

MaxMetaspaceSize: unlimited

The root cause of the problem is that the MaxMetaspaceSize rounding performed during arguments parsing is inconsistent with the round checking in print_settings(metaspaceRerporter.cpp).

-------------

Commit messages:
 - jcmd VM.metaspace should report unlimited size

Changes: https://git.openjdk.java.net/jdk/pull/2671/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2671&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8262099
  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2671.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2671/head:pull/2671

PR: https://git.openjdk.java.net/jdk/pull/2671


More information about the hotspot-runtime-dev mailing list