RFR: 8262099: jcmd VM.metaspace should report unlimited size if MaxMetaspaceSize isn't specified

[David Holmes]

On Mon, 22 Feb 2021 03:21:45 GMT, Yang Yi <github.com+5010047+kelthuzadx at openjdk.org> wrote:

> Hi,
> 
> Can I have a review of this minor fix about `jcmd VM.metaspace`?
> 
> When MaxMetaspaceSize is not specified, it would set to max_uintx, jcmd VM.metaspace reports metaspace summary information as follows:
> 
> $ ./jcmd <pid> VM.metaspace | grep MaxMetaspaceSize
> MaxMetaspaceSize: 17179869184.00 GB
> 
> Actually, this is a bug, the expected output should be:
> 
> MaxMetaspaceSize: unlimited
> 
> The root cause of the problem is that the MaxMetaspaceSize rounding performed during arguments parsing is inconsistent with the round checking in print_settings(metaspaceRerporter.cpp).

src/hotspot/share/memory/metaspace/metaspaceReporter.cpp line 3:

> 1: /*
> 2:  * Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
> 3:  * Copyright (c) 2018, 2021 SAP SE. All rights reserved.

Please note that while Oracle requests/requires that it's copyright line gets updated each year a file is modified, it is not clear whether that extends to any other copyright lines that might appear in the file. In general for companies other than Oracle, only a committer from that company should update a copyright line for that company.

Thanks,
David

-------------

PR: https://git.openjdk.java.net/jdk/pull/2671