RFR: 8262094: Handshake timeout scaled wrong

[Robbin Ehn]

Hi David,

> 
> > In a virtualized env. this causes a 20.000 ms timeout to timeout
> > after 2 s for me due to low resolution (windows only).
> > (all other platforms hardcoded to NANASECONDS)
> > 
> > We have two more suspective uses here, which I have not
> > investigated (but we have seem wired timeouts with both ZGC and G1,
> > but I have seen non with parGC):
> > `open/src/hotspot/share/gc/z/zMark.cpp:     
> > _timeout(_start.value() +
> > TimeHelper::micros_to_counter(timeout_in_micros))`
> > 
> > `open/src/hotspot/share/gc/g1/g1ServiceThread.cpp:  jlong delay =
> > TimeHelper::millis_to_counter(delay_ms);`
> 

FYI: I looked at these and they are fine.


> These should only be heuristics in any case, but I don't understand
> why 
> we would want to express a delay/timeout this way.

I don't either.

Thanks, Robbin

> 
> Cheers,
> David
> -----
> 
> > Thanks
> > 
> > -------------
> > 
> > PR: https://git.openjdk.java.net/jdk/pull/2666
> >